[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

[Kees Cook via Phabricator via cfe-commits]

kees added inline comments.


================
Comment at: test/Analysis/asm-goto.cpp:1
+// RUN: %clang_analyze_cc1 -analyzer-checker=debug.DumpCFG %s 2>&1 | FileCheck %s
+
----------------
Based on Nathan's comments in another thread, it seems like this needs to be:

```
// REQUIRES: x86-registered-target
// RUN: %clang_analyze_cc1 -triple x86_64 -analyzer-checker=debug.DumpCFG %s 2>&1 | FileCheck %s
```


================
Comment at: test/CodeGen/asm-goto.c:1
+// RUN: %clang_cc1 -O0 -emit-llvm  %s -o - | FileCheck %s
+
----------------
Based on Nathan's comments in another thread, it seems like this needs to be:

```
// REQUIRES: x86-registered-target
// RUN: %clang_cc1 -O0 -triple x86_64 -emit-llvm  %s -o - | FileCheck %s
```


================
Comment at: test/Sema/asm-goto.cpp:1
+// RUN: %clang_cc1 %s -triple i386-pc-linux-gnu -verify -fsyntax-only
+
----------------
Based on Nathan's comments in another thread, it seems like this needs to be:

```
// REQUIRES: x86-registered-target
// RUN: %clang_cc1 -triple x86_64 -fsyntax-only -verify -fblocks -std=gnu99 %s -Wno-unreachable-code
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56571/new/

https://reviews.llvm.org/D56571