[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

[Dmitri Gribenko via Phabricator via cfe-commits]

gribozavr added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:54
+
+void e() {
+  int pipefd[2];
----------------
srhines wrote:
> gribozavr wrote:
> > How is `e` different from `a`?
> `e` uses O_CLOEXEC properly with `pipe2()` and makes sure that we don't issue additional diagnostics/fixes that are unnecessary.
Thanks -- I see it now.  I think a descriptive test name would help here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62049/new/

https://reviews.llvm.org/D62049