[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.
Stephen Hines via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 31 13:05:54 PDT 2019
srhines added inline comments.
Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe.cpp:17
+ // CHECK-MESSAGES-NOT: warning:
> nit: no need to do it explicitly, if a warning is shown unexpectedly, the test will fail.
I somehow never realized this (and there seem to be several places that also don't realize it). Thanks for letting us know.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits