[PATCH] D62611: [analyzer][Dominators] Add unittests

[Jakub Kuderski via Phabricator via cfe-commits]

kuhar added inline comments.


================
Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:95
+  CFGPostDomTree PostDom;
+  PostDom.buildDominatorTree(cfg);
+
----------------
Why not have a constructor that takes the cfg and constructs a domtree straight away? But this should probably go into a separate patch.


================
Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:113
+  EXPECT_TRUE(PostDom.dominates(ExitBlock, ExitBlock));
+  EXPECT_FALSE(Dom.properlyDominates(ExitBlock, ExitBlock));
+}
----------------
A tastcase with a virtual root postdominating other nodes would be welcome.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62611/new/

https://reviews.llvm.org/D62611