[PATCH] D62335: [OpenCL][PR41963] Add overloads of old atomics with generic pointer type in C++ mode

Sven van Haastregt via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 29 08:44:05 PDT 2019


svenvh accepted this revision.
svenvh added a comment.
This revision is now accepted and ready to land.

LGTM, please address style issue before committing.



================
Comment at: test/Headers/opencl-c-header.cl:79
+{
+    atomic_add(a, 1);
+}
----------------
Probably better to follow the style of the other tests above (i.e. indent and brace placement).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62335/new/

https://reviews.llvm.org/D62335





More information about the cfe-commits mailing list