[PATCH] D62514: [CodeComplete] Set preferred type for qualified-id
Ilya Biryukov via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 28 07:32:07 PDT 2019
ilya-biryukov added a comment.
In D62514#1518941 <https://reviews.llvm.org/D62514#1518941>, @kadircet wrote:
> thanks, lgtm.
> one irrelevant question though, it looks like most of the calls to `ResultBuilder::setPreferredType` performs a `!isNull` check before hand. should we perform this check implicitly and make the `setPreferredType` no-op in case of a null type?
I don't see any reason why not, that could save some typing.
Better yet, we might be able to remove it altogether. Preferred type is also stored in completion context and I'm not sure whether it's ever different from the one in `ResultBuilder`.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits