[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate
Aaron Puchert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 27 16:49:26 PDT 2019
aaronpuchert updated this revision to Diff 201597.
aaronpuchert marked an inline comment as done.
aaronpuchert added a comment.
Put the important part first, and the rest in a separate sentence.
CHANGES SINCE LAST ACTION
@@ -423,6 +423,9 @@
driver, they should only be used when it's very likely they match the user's
* Clang must recover from errors as if the fix-it had been applied.
+* Fix-it hints on a warning must not change the meaning of the code.
+ However, a hint may clarify the meaning as intentional, for example by adding
+ parentheses when the precedence of operators isn't obvious.
If a fix-it can't obey these rules, put the fix-it on a note. Fix-its on notes
are not applied automatically.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 667 bytes
Desc: not available
More information about the cfe-commits