[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 27 08:08:02 PDT 2019

aaron.ballman requested changes to this revision.
aaron.ballman added a comment.
This revision now requires changes to proceed.

It seems that the functional changes are missing from the patch -- all I see are formatting changes; have I missed something?

Comment at: clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsCallsCheck.cpp:24-25
   const auto *S = Result.Nodes.getNodeAs<CXXDefaultArgExpr>("stmt");
-  if (S == nullptr) return;
+  if (S == nullptr)
+    return;
Given that the only change in the file is a formatting change, I would revert this. Feel free to commit separately as an NFC commit if you plan to do future work in the file.

Comment at: clang-tools-extra/clang-tidy/fuchsia/DefaultArgumentsDeclarationsCheck.h:1
+//===--- DefaultArgumentsDeclarationsCheck.h - clang-tidy ------------------*- C++ -*-===//
Eugene.Zelenko wrote:
> Please narrow to 80 symbols.
This should similarly be a separate NFC commit.



More information about the cfe-commits mailing list