[PATCH] D62298: [CodeComplete] Filter override completions by function name

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 23 09:25:21 PDT 2019


ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.

I think that's a good step forward, although not yet ideal. The typed chunk now contains everything starting function name and ending with `override`, so one gets both nice prefix match scores when typing a function and possibility to say `override` to get all completion items that do overrides.



================
Comment at: clang/test/CodeCompletion/overrides.cpp:29
-//
-// Runs completion at void ^.
-// RUN: %clang_cc1 -fsyntax-only -code-completion-at=%s:14:8 %s -o - | FileCheck -check-prefix=CHECK-CC3 %s
----------------
I've removed this to avoid dealing with the error return code (`vfo` is unresolved, so clang produces error there).
Happy to bring it back if you feel it's important


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62298/new/

https://reviews.llvm.org/D62298





More information about the cfe-commits mailing list