[PATCH] D62320: Fix LLVM_LINK_LLVM_DYLIB build after rC361285

Sam Clegg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 23 07:58:22 PDT 2019


sbc100 created this revision.
Herald added subscribers: cfe-commits, aheejin, mgorny.
Herald added a project: clang.

All the other unittests I can find specify LLVMTestingSupport in
target_link_libraries not as part of LLVM_LINK_COMPONENTS.

I'm how/why this fixes the build issue, but its consistent with
other uses.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D62320

Files:
  clang/unittests/Tooling/CMakeLists.txt


Index: clang/unittests/Tooling/CMakeLists.txt
===================================================================
--- clang/unittests/Tooling/CMakeLists.txt
+++ clang/unittests/Tooling/CMakeLists.txt
@@ -1,7 +1,6 @@
 set(LLVM_LINK_COMPONENTS
   ${LLVM_TARGETS_TO_BUILD}
   Support
-  TestingSupport
   )
 
 # By default MSVC has a 2^16 limit on the number of sections in an object file,
@@ -71,6 +70,7 @@
   clangToolingCore
   clangToolingInclusions
   clangToolingRefactor
+  LLVMTestingSupport
   )
 
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62320.200976.patch
Type: text/x-patch
Size: 506 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190523/b1f277be/attachment.bin>


More information about the cfe-commits mailing list