[PATCH] D62288: [clangd-vscode] Do not customize uri converters in vscode

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 23 01:27:51 PDT 2019


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM, this improves the paths produced for generated files inside `bazel-genfiles`, we now point to the `/my/project/bazel-genfiles/path/to/some.proto.h` instead of `/path/to/bazel/internals/<hashes>/path/to/some.proto.h`



================
Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:3
 import * as vscodelc from 'vscode-languageclient';
 import { realpathSync } from 'fs';
 
----------------
NIT: remove this import, we don't need it anymore


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62288/new/

https://reviews.llvm.org/D62288





More information about the cfe-commits mailing list