[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

Hans Wennborg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 22 04:20:59 PDT 2019


hans added inline comments.


================
Comment at: lib/Frontend/TextDiagnostic.cpp:768
     if (Dir) {
+#ifdef _WIN32
+      SmallString<4096> DirName = Dir->getName();
----------------
I think this requires a comment explaining why Windows is handled differently.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59415/new/

https://reviews.llvm.org/D59415





More information about the cfe-commits mailing list