[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

Tom Rix via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 21 20:02:26 PDT 2019


trixirt marked an inline comment as done.
trixirt added inline comments.


================
Comment at: clang-tidy/bugprone/HeaderGuardCheck.cpp:30
+}
+std::string BugproneHeaderGuardCheck::getHeaderGuard(StringRef Filename,
+                                                     StringRef OldGuard) {
----------------
aaron.ballman wrote:
> Can you add a newline for some visual separation?
I did not think ment a empty newline in the param-list, so  I assumed you ment the function above and this function could use a new line.  


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61508/new/

https://reviews.llvm.org/D61508





More information about the cfe-commits mailing list