[PATCH] D62045: Modified global variable declaration to fit updated objc guide.

Yaqi Ji via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 20 21:47:11 PDT 2019


yaqiji updated this revision to Diff 200399.
yaqiji marked 2 inline comments as done.
yaqiji added a comment.
Herald added a subscriber: mgorny.

Modified CMakeList to include tests, otherwise clangTidyGoogleModule wouldn't compile. 
Added k_Alpha test case back. 
Added Extern case so that if it is a extern global constant, no suggestion will show up. 
Removed .* and leave substrings only for matching.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62045/new/

https://reviews.llvm.org/D62045

Files:
  clang-tools-extra/clang-tidy/google/CMakeLists.txt
  clang-tools-extra/clang-tidy/google/GlobalVariableDeclarationCheck.cpp
  clang-tools-extra/test/clang-tidy/google-objc-global-variable-declaration.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62045.200399.patch
Type: text/x-patch
Size: 8387 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190521/267b9cd2/attachment.bin>


More information about the cfe-commits mailing list