[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

[Akira Hatanaka via Phabricator via cfe-commits]

ahatanak marked an inline comment as done.
ahatanak added inline comments.


================
Comment at: lib/AST/ASTContext.cpp:6973
     QualType PointeeTy = OPT->getPointeeType();
-    if (!Options.EncodingProperty() &&
+    if (getLangOpts().ObjCRuntime.isGNUFamily() &&
+        !Options.EncodingProperty() &&
----------------
theraven wrote:
> Please can we at least make this check just for the GCC runtime?  I'm not sure it's even needed there.  I've previously had to write code that works around this and have always considered it a bug in GCC, rather than a feature that I'd like us to copy, so I'd also be happy with just deleting this code path entirely.
> 
Are we allowed to delete the code path entirely? That would clean up the code a bit, but I assume it would also break GCC runtime users' code.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61974/new/

https://reviews.llvm.org/D61974