[PATCH] D60283: [DebugInfo] Don't emit checksums when compiling a preprocessed CPP

Alexandre Ganea via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 15 12:32:30 PDT 2019


aganea updated this revision to Diff 199659.
aganea marked 3 inline comments as done.
aganea added a comment.

In D60283#1503256 <https://reviews.llvm.org/D60283#1503256>, @probinson wrote:

> Minor stuff.  This solution is surprisingly simple, the main question being (and I don't have an answer) whether increasing the size of PresumedLoc is okay.


Thanks Paul! `PresumedLoc` seems to be used only as a temporary (on the stack).


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60283/new/

https://reviews.llvm.org/D60283

Files:
  include/clang/Basic/SourceLocation.h
  lib/Basic/SourceManager.cpp
  lib/CodeGen/CGDebugInfo.cpp
  test/CodeGen/Inputs/debug-info-file-checksum-line.cpp
  test/CodeGen/Inputs/debug-info-file-checksum-pre.cpp
  test/CodeGen/debug-info-file-checksum.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D60283.199659.patch
Type: text/x-patch
Size: 5438 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190515/18feceed/attachment.bin>


More information about the cfe-commits mailing list