[PATCH] D61931: [Driver] Use --android-tls for Android ARM/AArch64 when lld is used

Ryan Prichard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 15 00:03:31 PDT 2019


rprichard added inline comments.


================
Comment at: lib/Driver/ToolChains/Gnu.cpp:404
+      const Arg *A = Args.getLastArg(options::OPT_fuse_ld_EQ);
+      if (A && StringRef(A->getValue()).contains("lld"))
+        CmdArgs.push_back("--android-tls");
----------------
The logic used for Fuschia is more precise:

  const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath());
  if (llvm::sys::path::filename(Exec).equals_lower("ld.lld") ||
      llvm::sys::path::stem(Exec).equals_lower("ld.lld")) {
    CmdArgs.push_back("-z");
    CmdArgs.push_back("rodynamic");
  }



Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61931/new/

https://reviews.llvm.org/D61931





More information about the cfe-commits mailing list