[PATCH] D61804: Support building shared and static libraries simultaneously

Wink Saville via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 13 14:16:07 PDT 2019


winksaville added a comment.

In D61804#1500445 <https://reviews.llvm.org/D61804#1500445>, @winksaville wrote:

> In D61804#1500409 <https://reviews.llvm.org/D61804#1500409>, @beanz wrote:
>
> > My change should not have decreased build time from trunk, nor should it have reduced the number of build steps. That patch should generate lib/libClang_shared.so, which will export the C++ API. libClang is unchanged since changing it would break existing clients of the library.
>
>
> OK, I'll look into what I've done wrong. If you see anything or have any guesses please let me know.


I found my mistake that caused the speed up, I'd aborted a previous build so ninja started where it left off, just as should :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61804/new/

https://reviews.llvm.org/D61804





More information about the cfe-commits mailing list