[PATCH] D61861: DeleteNullPointerCheck now deletes until the end brace of the condition
Mads Ravn via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon May 13 11:25:50 PDT 2019
madsravn added a comment.
Besides my one comment this looks good to me.
================
Comment at: clang-tools-extra/test/clang-tidy/readability-delete-null-pointer.cpp:9
// #1
- if (p) { // #2
+ if (p /**/) { // #2
delete p;
----------------
Would you mind creating a new test instead of changing the existing one? Removing tests could create another whole for a bug to fall through.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61861/new/
https://reviews.llvm.org/D61861
More information about the cfe-commits
mailing list