[PATCH] D61841: [clangd] Respect WarningsAsErrors configuration for clang-tidy

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 13 02:09:25 PDT 2019


ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/ClangdUnit.cpp:346
+      std::string CheckName = CTContext->getCheckName(Info.getID());
+      if (!CheckName.empty() && WarningAsErrorFilter->contains(CheckName)) {
+        Level = DiagnosticsEngine::Error;
----------------
Why can't we call `CTContext->treatAsError()` here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61841/new/

https://reviews.llvm.org/D61841





More information about the cfe-commits mailing list