[PATCH] D60456: [RISCV][WIP/RFC] Hard float ABI support

Alex Bradbury via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 9 05:25:51 PDT 2019


asb added inline comments.


================
Comment at: lib/CodeGen/TargetInfo.cpp:9223
+
+  bool IsInt = Ty->isIntegralOrEnumerationType();
+  bool IsFloat = Ty->isRealFloatingType();
----------------
rjmccall wrote:
> Should this include pointers?  Pointers are often interchangeably with integers by ABIs.
> 
> The same question also applies to C++ references and data-member-pointer types, and maybe others that I'm not thinking of.
The ABI doesn't consider pointers and integers interchangeable in this case. An "integer" is indeed an integer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60456/new/

https://reviews.llvm.org/D60456





More information about the cfe-commits mailing list