[PATCH] D61643: [PragmaHandler][NFC] Expose `#pragma` location

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 7 10:03:50 PDT 2019


lebedev.ri added reviewers: rsmith, aaron.ballman.
lebedev.ri added a comment.

Seems like obvious NFC to me, but i'm not sure about API/ABI implications for external use.



================
Comment at: clang/docs/ClangPlugins.rst:58
     ExamplePragmaHandler() : PragmaHandler("example_pragma") { }
-    void HandlePragma(Preprocessor &PP, PragmaIntroducerKind Introducer,
+    void HandlePragma(Preprocessor &PP, PragmaIntroducer Introducer,
                       Token &PragmaTok) {
----------------
Hmm.
This will have effects on out-of-tree plugins that define pragmas.
I'm not sure how to proceed here, just notify cfe-dev and move on?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61643/new/

https://reviews.llvm.org/D61643





More information about the cfe-commits mailing list