[PATCH] D61497: [clangd] Introduce a structured hover response

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 7 07:18:08 PDT 2019


ilya-biryukov added inline comments.


================
Comment at: clang-tools-extra/clangd/XRefs.h:53
+struct HoverInfo {
+  using Type = std::string;
+  struct Param {
----------------
NIT: maybe go with `std::string Type` at a use-site instead?
The scope of the name is large enough to make single-letter names a bit confusing


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61497/new/

https://reviews.llvm.org/D61497





More information about the cfe-commits mailing list