[PATCH] D61596: [clangd] Move Rename into its own file, and add unit test. NFC

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 7 00:04:40 PDT 2019


sammccall marked 2 inline comments as done.
sammccall added inline comments.


================
Comment at: clangd/ClangdServer.cpp:264
                           Callback<std::vector<TextEdit>> CB) {
-  auto Action = [Pos](Path File, std::string NewName,
+  auto Action = [Pos](std::string File, std::string NewName,
                       Callback<std::vector<TextEdit>> CB,
----------------
kadircet wrote:
> Why change Path to std::string ?
Oops, removed this capture and then re-added it.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61596/new/

https://reviews.llvm.org/D61596





More information about the cfe-commits mailing list