[PATCH] D49587: [CMake] Support exporting runtimes using the CMake export

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon May 6 15:09:45 PDT 2019


phosek added a comment.

In D49587#1488328 <https://reviews.llvm.org/D49587#1488328>, @smeenai wrote:

> Seems like you got the wrong diff.


It was the right diff but uploaded to a wrong change ;)

In D49587#1484829 <https://reviews.llvm.org/D49587#1484829>, @smeenai wrote:

> Sorry, had missed this.
>
> I realized later that LLVM's export setup is to support selectively exporting components using `LLVM_DISTRIBUTION_COMPONENTS`. Is there an equivalent to that in the runtimes world? If there is, the export installation should respect that; if not, this LGTM.


There's `LLVM_RUNTIME_DISTRIBUTION_COMPONENTS` which @beanz introduced a while back which is supposed to serve the same purpose. I wired it up but there were some other issues that were revealed while testing this change, hopefully those should be all addressed now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D49587/new/

https://reviews.llvm.org/D49587





More information about the cfe-commits mailing list