[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

Jim Ingham via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 3 10:23:22 PDT 2019


jingham added a comment.

IIUC, when Expected returns fails, it returns an Error object that might have information about what went wrong.  Would it be possible to include the contents of that error n the log message?  We often get "I can't run an expression in a really complex proprietary code base" and need to try to sort out what went wrong from these logs.  So every crumb of information we can preserve is useful...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61438/new/

https://reviews.llvm.org/D61438





More information about the cfe-commits mailing list