[PATCH] D61015: [LibTooling] Change Transformer's TextGenerator to a partial function.

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 30 11:00:54 PDT 2019


ymandel added a comment.

In D61015#1484669 <https://reviews.llvm.org/D61015#1484669>, @thakis wrote:

> This breaks a test:  http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/12112/steps/check-llvm%20check-clang%20stage3%2Fmsan/logs/stdio
>
>   [----------] 1 test from TransformerTest
>   [ RUN      ] TransformerTest.NodePartNameDeclRefFailure
>   /b/sanitizer-x86_64-linux-bootstrap-msan/build/llvm/tools/clang/unittests/Tooling/TransformerTest.cpp:66: Failure
>   Value of: MaybeActual
>     Actual: false
>   Expected: true
>   Rewrite failed. Expecting: 
>       struct Y {
>         int operator*();
>       };
>       int neutral(int x) {
>         Y y;
>         int (Y::*ptr)() = &Y::operator*;
>         return *y + x;
>       }
>    
>   [  FAILED  ] TransformerTest.NodePartNameDeclRefFailure (83 ms)
>   [----------] 1 test from TransformerTest (83 ms total)
>
>
> Can you take a look?


Fixed in r359578.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61015/new/

https://reviews.llvm.org/D61015





More information about the cfe-commits mailing list