[PATCH] D61220: lib/Header: Fix Visual Studio builds try #2

[Vyacheslav Zakharin via Phabricator via cfe-commits]

vzakhari added inline comments.


================
Comment at: clang/lib/Headers/CMakeLists.txt:173
 
 set(header_install_dir lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION})
 
----------------
Please add "/include" at the end.


================
Comment at: clang/lib/Headers/CMakeLists.txt:176
 install(
-  DIRECTORY ${output_dir}
+  FILES ${install_files}
   DESTINATION ${header_install_dir}
----------------
This is going to flatten the headers' install directory structure.  install() will put the files just by their name.

I had a local fix that use install() with RENAME, and it worked.  I can try to find it.  Basically, we need to keep two lists:
1. The same as this ${install_files}
2. New list install_as, which holds all ${src} values passed to copy_header_to_output_dir()

Walking the two lists together we may use install(FILES ${elt_from_install_files} RENAME ${elt_from_install_as} ...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61220/new/

https://reviews.llvm.org/D61220