[PATCH] D59168: [runtimes] Move libunwind, libc++abi and libc++ to lib/clang/ and include/

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 25 22:26:09 PDT 2019


phosek added a comment.

In D59168#1474715 <https://reviews.llvm.org/D59168#1474715>, @jdenny wrote:

> Does the following match what you have in mind?
>
>   $prefix/
>     include/
>       c++/
>         v1/
>           limits.h
>           ...
>       openmp/
>         v1/ <------ I don't think openmp has anything like this now


Iibc++ uses this scheme to allow the possibility of evolving the API but I'm not sure if it's necessary for openmp.

>         omp.h
>         ompt.h
>         ...
>   lib/
>     c++/
>       $target/
>         libc++abi.so
>         ...
>     openmp/
>       $target/
>         libomp.so
>         ...
>     clang/
>       9.0.0/ <----- resource directory
>         include/
>         lib/
>           $target/
>             libclang_rt.asan_cxx.a
>             ...
> 
>   

Almost with a small variation:

  $prefix/
    include/
      c++/
        v1/
          limits.h
          ...
      openmp/
        omp.h
        ompt.h
        ...
    lib/
      $target/ <--- This way we don't have to duplicate $target in each subdirectory and it matches the layout of the resource directory
        c++/
          libc++abi.so
          ...
        openmp/
          libomp.so
          ...
      clang/
        9.0.0/
          include/
          lib/
            $target/
              libclang_rt.asan_cxx.a
              ...

WDYT?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59168/new/

https://reviews.llvm.org/D59168





More information about the cfe-commits mailing list