[PATCH] D60907: [OpenMP] Add math functions support in OpenMP offloading
Gheorghe-Teodor Bercea via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 25 13:11:25 PDT 2019
gtbercea added a comment.
In D60907#1479298 <https://reviews.llvm.org/D60907#1479298>, @gtbercea wrote:
> In D60907#1479142 <https://reviews.llvm.org/D60907#1479142>, @hfinkel wrote:
> > In D60907#1479118 <https://reviews.llvm.org/D60907#1479118>, @gtbercea wrote:
> > > Ping @hfinkel @tra
> > The last two comments in D47849 <https://reviews.llvm.org/D47849> indicated exploration of a different approach, and one which still seems superior to this one. Can you please comment on why you're now pursuing this approach instead?
> This solution is following Alexey's suggestions. This solution allows the optimization of math calls if they apply (example: pow(x,2) => x*x ) which was one of the issues in the previous solution I implemented.
CHANGES SINCE LAST ACTION
More information about the cfe-commits