r359048 - C++ DR2387: a variable template declared wtih (or instantiated with) a

[Richard Smith via cfe-commits]

Thanks for the revert.

Looks like this is probably an unfortunate interaction with the
internal_linkage attribute.

On Wed, 24 Apr 2019, 01:48 Ilya Biryukov via cfe-commits, <
cfe-commits at lists.llvm.org> wrote:

> Reverted in r359076.
>
> On Wed, Apr 24, 2019 at 10:28 AM Ilya Biryukov <ibiryukov at google.com>
> wrote:
>
>> Hi Richard,
>>
>> This seems to break libc++, found while doing an integrate. The errors
>> are:
>>
>> In file included from valarray:4:
>> .../include/c++/v1/valarray:1062:60: error: explicit instantiation
>> declaration of 'valarray<_Tp>' with internal linkage
>> _LIBCPP_EXTERN_TEMPLATE(_LIBCPP_FUNC_VIS
>> valarray<size_t>::valarray(size_t))
>>                                                            ^
>> .../include/c++/v1/valarray:1063:60: error: explicit instantiation
>> declaration of '~valarray<_Tp>' with internal linkage
>> _LIBCPP_EXTERN_TEMPLATE(_LIBCPP_FUNC_VIS valarray<size_t>::~valarray())
>>                                                            ^
>>
>> I will likely revert the change to unbreak the integrate.
>>
>>
>
> --
> Regards,
> Ilya Biryukov
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190424/acb1d7e5/attachment.html>