[PATCH] D61040: [Fuchsia] Support multilib for -fsanitize=address and -fno-exceptions
Jon Roelofs via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 24 04:43:55 PDT 2019
On Tue, Apr 23, 2019 at 11:36 PM Petr Hosek via Phabricator <
reviews at reviews.llvm.org> wrote:
> phosek added inline comments.
> Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:122
> +/// \p Flag must be a flag accepted by the driver with its leading '-'
> +// otherwise '-print-multi-lib' will not emit them correctly.
> jroelofs wrote:
> > Can we enforce this precondition with an assert? The
> '-'-prefix-not-there part is easy, but what about the "it's a driver flag"
> We could, but we would need to pass in the reference to `Driver` so we can
> use `getOpts().ParseOneArg` to parse the flag. However, we're not doing
> that in `Multilib` either at the moment even though [the comment says it
> has to be a valid flag](
> I'd prefer to keep this as a pure move and then add the additional checking
> both here and to `Multilib` as a separate change, would that be fine with
Sure, that works.
> rC Clang
> CHANGES SINCE LAST ACTION
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits