[PATCH] D60967: Move setTargetAttributes after setGVProperties in SetFunctionAttributes
Scott Linder via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 23 12:06:26 PDT 2019
scott.linder added a comment.
In D60967#1475925 <https://reviews.llvm.org/D60967#1475925>, @rjmccall wrote:
> It seems reasonable to me for target hooks to run after global hooks, but can I ask why AMDGPU specifically relies on this?
We want to ensure certain symbols have a meaningful visibility. For example, kernel symbols must not have hidden visibility. It's reasonable for the user to arrange for a kernel symbol to have either protected or default visibility, though, so we want our hook to be run after the global hooks have already calculated the global visibility.
CHANGES SINCE LAST ACTION
More information about the cfe-commits