[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

Jinsong Ji via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 23 08:05:12 PDT 2019


jsji added a comment.

Thanks @MaskRay for help fixing and review!



================
Comment at: lib/Headers/ppc_wrappers/mmintrin.h:3
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
----------------
MaskRay wrote:
> This is not Apache 2.
Ah.. This was aligned with other headers .. but forgot to update to Apache 2.

@qiucf Please update it to Apache 2 as well. Thanks.


================
Comment at: lib/Headers/ppc_wrappers/mmintrin.h:24
+
+/* Implemented from the specification included in the Intel C++ Compiler
+   User Guide and Reference, version 9.0.  */
----------------
MaskRay wrote:
> Is this considered a derivative work of the Intel C++ Compiler?
My understanding is that the `User Guide and Reference ` is the `specification` , implementation based on public specification should NOT be considered as `derivative` work. 

Otherwise, all codes that referenced `User Guide and Reference ` need to be considered derivative work?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59924/new/

https://reviews.llvm.org/D59924





More information about the cfe-commits mailing list