[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

Don Hinton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Apr 21 09:55:55 PDT 2019


hintonda marked an inline comment as done.
hintonda added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/rename_check.py:218
   header_guard_variants = [
+      (args.old_check_name.replace('-', '_') + '_Check').upper(),
+      (old_module + '_' + check_name_camel).upper(),
----------------
alexfh wrote:
> s/_Check/_CHECK/, maybe?
Not sure it matters, but args.old_check_name is all lower case, so we have to uppercase the entire string.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60629/new/

https://reviews.llvm.org/D60629





More information about the cfe-commits mailing list