[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

Richard Townsend (Arm) via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 18 10:43:31 PDT 2019


richard.townsend.arm added inline comments.


================
Comment at: lib/CodeGen/MicrosoftCXXABI.cpp:1090
+    FI.getReturnInfo().setSRetAfterThis(isInstanceMethod);
+    FI.getReturnInfo().setInReg(isAArch64 && isIndirectReturn);
 
----------------
Based on https://reviews.llvm.org/D60348 - lib/Target/AArch64/AArch64CallingConvention.td (line 44), should this be (isIndirectReturn || isInstanceMethod)? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60349/new/

https://reviews.llvm.org/D60349





More information about the cfe-commits mailing list