[PATCH] D60822: [clangd] Use shorter, more recognizable codes for diagnostics.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Apr 17 13:12:16 PDT 2019


sammccall added a comment.

In D60822#1470227 <https://reviews.llvm.org/D60822#1470227>, @kadircet wrote:

> I agree that these are more useful. What about also adding "-W" in front of warning flags to make them more explicit and stand out from "non-flag" error names?


I went back and forth on this, I think you're probably right. It's consistent with how clang-tidy check names vs warnings are exposed to users: "Diag text [-Wfoo]" and "Diag text [check-name]".
Let's see how it goes.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60822/new/

https://reviews.llvm.org/D60822





More information about the cfe-commits mailing list