[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals
Don Hinton via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Apr 17 08:41:21 PDT 2019
hintonda marked an inline comment as done.
hintonda added inline comments.
Comment at: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp:27-28
> aaron.ballman wrote:
> > hintonda wrote:
> > > aaron.ballman wrote:
> > > > Please keep this list sorted alphabetically.
> > > I think this is where add_new_check.py put it, but I'll alphabetize.
> > Huh, I thought that script kept everything alphabetized? That may be worth investigating (don't feel obligated though).
> I'm sure it's something I did inadvertently, but can't really remember the details.
Looks like rename_check.py definitely does not alphabetize. I'll try to address than in another patch. Thanks for pointing this out.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the cfe-commits