[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

Joel E. Denny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 16 11:44:30 PDT 2019

jdenny added a comment.

> Just wanted to give a bit more visibility to the underrated technology of writing -verify=a,b,c instead of the #ifdefclutter.

It's great to see this getting more use.

> It's also a bit wonky because it seems that you have to write an exponential number of flags to verify in order to have full flexibility (which is why i didn't update the #ifdef DFS test), but it still seems to be much better in most cases.

Sometimes you can avoid an explosion of FileCheck prefixes using -D.  I'm not aware of anything like -D for -verify.

In D60732#1467504 <https://reviews.llvm.org/D60732#1467504>, @Charusso wrote:

> It is a cool reveal, could you provide a documentation?

The original patch added documentation to `-cc1 -help`.  Doxygen for VerifyDiagnosticConsumer is another possibility except it currently doesn't mention command-line usage at all.  Maybe it should?

  rC Clang



More information about the cfe-commits mailing list