[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 16 07:17:49 PDT 2019


kadircet added inline comments.


================
Comment at: unittests/clangd/DiagnosticsTests.cpp:620
 
+ParsedAST build(const std::string &MainFile,
+                const llvm::StringMap<std::string> &Files) {
----------------
ilya-biryukov wrote:
> We were discussing adding the extra files to `TestTU` instead.
> Any reason this did not work out?
Yes, my LRU cache evicted the discussion :D


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59302/new/

https://reviews.llvm.org/D59302





More information about the cfe-commits mailing list