[PATCH] D60687: [clangd] Check file path of declaring header when deciding whether to insert include.
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 16 01:52:20 PDT 2019
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
IIUC, this already fixes the cases we'd seen of include-insertion of a header into itself.
Is it feasible to add a test case for that?
Comment at: clangd/Headers.h:140
- /// \param DeclaringHeader is the original header corresponding to \p
+ /// \param DeclaringHeader is path of the original header corresponding to \p
/// InsertedHeader e.g. the header that declares a symbol.
is the path
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
More information about the cfe-commits