[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

Mandeep Singh Grang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 12 13:43:52 PDT 2019


mgrang marked an inline comment as done.
mgrang added a comment.

In D60349#1462638 <https://reviews.llvm.org/D60349#1462638>, @ostannard wrote:

> The document you linked in the LLVM change (https://docs.microsoft.com/en-us/cpp/build/arm64-windows-abi-conventions?view=vs-2019#return-values) says that small POD types are returned directly in X0 or X0 and X1, but this looks like it will always return them indirectly. I think we also need to check the size of the type, and fall back the the plain C ABI for small types.





CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60349/new/

https://reviews.llvm.org/D60349





More information about the cfe-commits mailing list