[PATCH] D60151: [clang-tidy] Rename llvm checkers to llvm-project

Don Hinton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 11 15:47:46 PDT 2019


hintonda added a comment.

In D60151#1463484 <https://reviews.llvm.org/D60151#1463484>, @MyDeveloperDay wrote:

> >> I suppose we could keep the names and directory structure and just change the namespace.  That would just be a special case in the scripts.  Haven't looked into it yet, but will do so as soon as I can.
> > 
> > Isn't that matching done on strings? I.e. is there difference between `-llvm-*` and `-ll*` ?
>
> it would be if they only do it to -llm-* (which could possibly catch most cases)
>
> but what if someone is doing
>
> -llvm-header-guard
>
> We wouldn't catch those..
>
> This is a snippet of a .clang-tidy file from a  project I work on, we turn off specific checks by fully qualifying the checker
>
>   ....
>   llvm-*,
>   -llvm-header-guard,
>   -llvm-include-order,
>   misc-*,
>   modernize-*,
>   ...
>


You make a great point.  I'll look into just changing the namespace name.  I wasn't really comfortable with all the code churn it involved anyway, but once I got started, I figured I'd finish it.  The duplicate `llvm` namespace is the issue, not other names.  Thanks for the feedback...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60151/new/

https://reviews.llvm.org/D60151





More information about the cfe-commits mailing list