[PATCH] D60573: [Sema] ADL: Associated namespaces for class types and enumeration types (CWG 1691)

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 11 15:27:08 PDT 2019


rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

Hmm.  Does this never impact code that's just using a locally-defined type within its scope?  I guess if ADL is involved, unqualified lookup must have reached the scope of the innermost namespace, and so it would be searching that namespace anyway.

In that case, I think I'm mollified that the source-compatibility risk is low and we should just unconditionally apply the new rule.  LGTM.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60573/new/

https://reviews.llvm.org/D60573





More information about the cfe-commits mailing list