[PATCH] D59746: [LibTooling] Fix '-h' option

Don Hinton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 9 08:34:30 PDT 2019


hintonda added a comment.

In D59746#1459906 <https://reviews.llvm.org/D59746#1459906>, @hintonda wrote:

> In D59746#1459826 <https://reviews.llvm.org/D59746#1459826>, @hintonda wrote:
>
> > In D59746#1459672 <https://reviews.llvm.org/D59746#1459672>, @klimek wrote:
> >
> > > If we can extend cl::alias to support this, we could give it a priority and take the highest prio :)
> >
> >
> > Okay, I'll give it that old college try, and see if I can come up with something not too kludgy.  ;-)
>
>
> Btw, do you just want default aliases, or default options in general?


I hope you don't mind, but I've got a few more design questions:

- should the default api be public, usable by Clang Tooling, or just usable within CommandLine.cpp?
- which options should be hard-coded, i.e., status quo, and which should be defaulted.
- should we provide some sort of diagnostic to user to alert them that they have overwritten a defaulted options -- note this has to happen at runtime.  Guess it could be a help option, a la hidden-help, that shows status of each option. I actually like the idea of option origin in general.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59746/new/

https://reviews.llvm.org/D59746





More information about the cfe-commits mailing list