[PATCH] D60418: inline asm: Don't copy llvm::MemoryBuffers when showing diagnostics

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 8 12:34:03 PDT 2019


thakis marked an inline comment as done.
thakis added inline comments.


================
Comment at: clang/lib/Lex/Lexer.cpp:2355
+  // XXX so comment is handled before pp directive is done, so no linetable
+  // entry yet when the handler runs.
   if (ParsingPreprocessorDirective || CurPtr == BufferEnd) {
----------------
It doesn't show up well in the diff, but there's a call to HandleComment() 13 lines further up that this refers to.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60418/new/

https://reviews.llvm.org/D60418





More information about the cfe-commits mailing list