[PATCH] D60055: Check i < FD->getNumParams() before querying

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 8 08:09:55 PDT 2019


lebedev.ri added inline comments.


================
Comment at: clang/test/SemaCXX/PR41139.cpp:3
+
+// expected-no-diagnostics
+
----------------
Add a comment what this test does?
('just checking that the crash does not happen again')


================
Comment at: clang/test/SemaCXX/cxx1y-generic-lambdas.cpp:946
+
+  int y = [](auto outer) {
+    return [](auto inner) {
----------------
Does this have to be in that namespace?
Can you put it into a new namespace referencing this review?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60055/new/

https://reviews.llvm.org/D60055





More information about the cfe-commits mailing list