[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

Fri Apr 5 07:03:06 PDT 2019

xazax.hun added a comment.

In D46421#1456155 <https://reviews.llvm.org/D46421#1456155>, @r.stahl wrote:

> Okay so I would suggest to go ahead and commit this. Rebased it succeeds without modification.
>
> Still leaves the open problems with the redecls. Should I add the failing test from https://reviews.llvm.org/D46421#1375147 in the same commit marked as expected to fail? Or what is the procedure here?

My last set of comments are also unresolved. Most of them are minor nits, but I would love to get rid of the code duplication between ClangExtDefMapGen and the Clang Static Analyzer regarding when do we consider a variable worth to import. Otherwise the patch looks good to me.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D46421/new/

https://reviews.llvm.org/D46421