[PATCH] D59449: [clang-tidy] Integrate clang-tidy-diff.py machinery into run-clang-tidy.py

[Alexander Kornienko via Phabricator via cfe-commits]

alexfh added a comment.

In D59449#1449664 <https://reviews.llvm.org/D59449#1449664>, @zinovy.nis wrote:

> > Why not just use clang-tidy-diff.py? The clang-tidy-diff.py script has a distinct and somewhat self-documenting name and a very specific purpose (find clang-tidy regressions in a patch), while run-clang-tidy.py is more focused on running over larger bodies of code with a purpose of analyzing or cleaning up. Is there any benefit in having all functionality in run-clang-tidy.py?
>
> Both scripts have almost the same implementation, almost the same syntax (at least after -j and -timeout we introduced). So why not merge them.


There are multiple (mostly user-facing) reasons to prefer separate scripts. Simplicity, focus, and internal consistency come to mind first. The clang-tidy-diff being separate and serving a single purpose makes it easier to find, understand, and use. If we merge the two scripts together, will it be easy to understand the different use-cases? Will all options be compatible? (E.g. -header-filter doesn't make much sense for the --diff mode, since the diff defines a different filter)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59449/new/

https://reviews.llvm.org/D59449