[PATCH] D55044: [clang-tidy] check for Abseil make_unique

Andy Zhang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 1 19:37:54 PDT 2019


axzhang marked an inline comment as done.
axzhang added inline comments.


================
Comment at: clang-tidy/modernize/MakeSmartPtrCheck.cpp:94
                                          equalsBoundNode(PointerType))))),
                                      CanCallCtor)
                               .bind(NewExpression)),
----------------
lebedev.ri wrote:
> ```
> CanCallCtor, anyOf(unless(IgnoreListInit), unless(hasInitializationStyle(CXXNewExpr::ListInit))))
> ```
I can't compile `unless(IgnoreListInit)`, but `unless(IgnoreListInit ? unless(anything()) : anything())` does work. I'm not sure how idiomatic that is though.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55044/new/

https://reviews.llvm.org/D55044





More information about the cfe-commits mailing list